[PATCH] D18158: Adding ability to unroll loops using epilogue remainder.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 15:07:49 PDT 2016


mzolotukhin added inline comments.

================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:301
@@ +300,3 @@
+      !UnrollRuntimeLoopRemainder(L, Count, AllowExpensiveTripCount,
+                                  UnrollRuntimeEpilog, LI, SE, DT, 
+                                  PreserveLCSSA))
----------------
Trailing whitespace.

================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:555-557
@@ -347,4 +554,5 @@
                                             PreHeaderBR);
-  Value *BECount = Expander.expandCodeFor(BECountSC, BECountSC->getType(),
+  Value *BECount = UseEpilogRemainder ? nullptr :
+                   Expander.expandCodeFor(BECountSC, BECountSC->getType(),
                                           PreHeaderBR);
 
----------------
I believe the patch for non-power-of-2 factor has already been committed. Could you please rebase this patch on ToT (and that would probably resolve my concern about BECount).


Repository:
  rL LLVM

http://reviews.llvm.org/D18158





More information about the llvm-commits mailing list