[PATCH] D17736: [SSP] Remove llvm.stackprotectorcheck.

[Kyle Butt via llvm-commits]

iteratee added a comment.

Mostly looks good.


================
Comment at: lib/CodeGen/StackProtector.cpp:346
@@ -432,1 +345,3 @@
       // fail BB generated by the stack protector pseudo instruction.
+      HasIRCheck = true;
+
----------------
Comment seems to belong to the instruction below. A comment about HasIRCheck would be nice too.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2179
@@ +2178,3 @@
+  unsigned Offset = (Subtarget.is64Bit()) ? 0x28 : 0x14;
+  unsigned AddressSpace = getAddressSpace();
+  PointerType *PtrTy = Type::getInt8PtrTy(M.getContext());
----------------
The address space will go away in a later patch, correct?


http://reviews.llvm.org/D17736