[PATCH] D18242: [TableGen] AsmMatcher: support for default values for optional operands

[Ahmed Bougacha via llvm-commits]

ab added a comment.

I haven't looked closely yet, but have you considered doing this entirely in tablegen, either via default operand lists (like ARM's OptionalDefOperand) or even some default value string?


================
Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:361
@@ -357,4 +360,3 @@
 
-  static std::unique_ptr<AMDGPUOperand> CreateImm(int64_t Val, SMLoc Loc,
-                                                  enum ImmTy Type = ImmTyNone,
-                                                  bool IsFPImm = false) {
+  static AMDGPUOperand::Ptr CreateImm(int64_t Val, SMLoc Loc,
+                                      enum ImmTy Type = ImmTyNone,
----------------
These look independent; feel free to commit right away (or submit another patch).


http://reviews.llvm.org/D18242