[PATCH] D18504: Bail as early as possible

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 28 01:50:00 PDT 2016


On 03/28, Sven Verdoolaege wrote:
> On Sun, Mar 27, 2016 at 09:22:32PM +0000, Johannes Doerfert wrote:
> > +      // Check if the maximal number of domain conjuncts was reached.
> > +      // In case this happens we will clean up and bail.
> > +      if (isl_set_n_basic_set(SuccDomain) <= MaxConjunctsInDomain)
> 
> You're not checking the number of conjuncts, but the number of *dis*juncts.
> "MaxConjunctsInDomain" is presumably also a misnomer.
Thanks for the input, I will fix this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160328/3495358b/attachment.sig>


More information about the llvm-commits mailing list