[llvm] r264554 - BitcodeWriter: Restructure WriteFunctionLocalMetadata, NFC

[Duncan P. N. Exon Smith via llvm-commits]

Author: dexonsmith
Date: Sun Mar 27 18:38:36 2016
New Revision: 264554

URL: http://llvm.org/viewvc/llvm-project?rev=264554&view=rev
Log:
BitcodeWriter: Restructure WriteFunctionLocalMetadata, NFC

Use an early return to simplify logic.

Modified:
    llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp

Modified: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=264554&r1=264553&r2=264554&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp (original)
+++ llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp Sun Mar 27 18:38:36 2016
@@ -1429,19 +1429,17 @@ static void WriteModuleMetadata(const Mo
 static void WriteFunctionLocalMetadata(const Function &F,
                                        const ValueEnumerator &VE,
                                        BitstreamWriter &Stream) {
-  bool StartedMetadataBlock = false;
+  ArrayRef<const Metadata *> MDs = VE.getFunctionMDs();
+  if (MDs.empty())
+    return;
+
+  Stream.EnterSubblock(bitc::METADATA_BLOCK_ID, 3);
+
   SmallVector<uint64_t, 64> Record;
-  for (const Metadata *MD : VE.getFunctionMDs()) {
-    auto *Local = cast<LocalAsMetadata>(MD);
-    if (!StartedMetadataBlock) {
-      Stream.EnterSubblock(bitc::METADATA_BLOCK_ID, 3);
-      StartedMetadataBlock = true;
-    }
-    WriteValueAsMetadata(Local, VE, Stream, Record);
-  }
+  for (const Metadata *MD : VE.getFunctionMDs())
+    WriteValueAsMetadata(cast<LocalAsMetadata>(MD), VE, Stream, Record);
 
-  if (StartedMetadataBlock)
-    Stream.ExitBlock();
+  Stream.ExitBlock();
 }
 
 static void WriteMetadataAttachment(const Function &F,