[PATCH] D18483: NFC: static_assert instead of comment

[JF Bastien via llvm-commits]

jfb added a comment.

For the record, the discussion on which llvm-commits didn't make it to phab:

> > > In http://reviews.llvm.org/D18483#383798, @dblaikie wrote:

> 

> > 

> 

> > > 

> 

> > 

> 

> > > > Could/should we be using a standard trait (std::is_trivially_copyable)?

> 

> > 

> 

> > > 

> 

> > 

> 

> > > 

> 

> > 

> 

> > > On Fri, Mar 25, 2016 at 3:33 PM, JF Bastien <jfb at chromium.org> wrote:

> 

> > 

> 

> > >  It's not available in libstdc++ before GCC 5.1.

> 

> > 

> 

> > 

> 

> > On Fri, Mar 25, 2016 at 3:37 PM, David Blaikie <dblaikie at gmail.com> wrote:

> 

> >  Ah, fair enough then - carry on. (consider this code review approval if you like (I'm by no means a code owner in this particular corner, but would be comfortable enough committing similar changes myself))

> 

> 

> No worries, I just figured I should open a PR in case anyone had a better idea than mine. The fix seemed strictly better than a comment, but hey it's Friday! I'll commit tomorrow if not :-)





Repository:
  rL LLVM

http://reviews.llvm.org/D18483