[PATCH] D18485: [profile] Add integration test to validate PGO function names

[Vedant Kumar via llvm-commits]

vsk added inline comments.

================
Comment at: test/profile/instrprof-visibility-kinds.inc:11
@@ +10,3 @@
+
+extern void f4();
+
----------------
davidxl wrote:
> Is this decl needed?
Not as written -- I should define it in another TU and make sure it shows up.

================
Comment at: test/profile/instrprof-visibility.cpp:39
@@ +38,3 @@
+
+// COV-DAG: _ZN2N12f1Ev
+// COV-DAG: instrprof-visibility.cpp:_ZN12_GLOBAL__N_12f1Ev
----------------
davidxl wrote:
> global f2 is missing in the check?
Good point. The name for f2 is not printed since there is only one expansion region. I'll update the test to check that f2() is at least covered properly.


http://reviews.llvm.org/D18485