[PATCH] D17736: [SSP, 1/2] Refactor to support customizable stack guard load from IR level.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 25 14:56:17 PDT 2016


timshen added inline comments.

================
Comment at: include/llvm/IR/Intrinsics.td:329
@@ +328,3 @@
+// target supports SSP in SelectionDAG. Otherwise SSP pass will generate IR
+// level code, including experimental_stackguardvalue calls. Backends may lower
+// experimental_stackguardvalue by overriding getStackGuardAddr and implementing
----------------
timshen wrote:
> Why do you think removing experimental is safer? Isn't keeping it in any situation a safer move?
First safer -> better


http://reviews.llvm.org/D17736





More information about the llvm-commits mailing list