[PATCH] D18415: [LTO] Basic support for internalize.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 20:33:01 PDT 2016


silvas added a subscriber: silvas.

================
Comment at: ELF/SymbolTable.cpp:221
@@ +220,3 @@
+  if (auto *BC = dyn_cast<DefinedBitcode>(Existing))
+    if (auto *U = dyn_cast<Undefined>(New))
+      BC->setUsedInRegularObj();
----------------
davide wrote:
> Can we use isUsedInRegularObj or do you prefer me to add a new flag isInRealELF?
DefinedElf and UndefinedElf already capture that distinction I think. I don't think a separate flag is necessary.


http://reviews.llvm.org/D18415





More information about the llvm-commits mailing list