[llvm] r264341 - [Support] Add ErrorInfo::ID static member definition.

[NAKAMURA Takumi via llvm-commits]

Lang, sorry for the issue. r264293 missed useful descriptions.

A static member's definition cannot be unified among DLLs in Win32 DLL
model, that has just "dllexport" and "dllimport".

Although Chandler is proposing to drop supporting Win32 DLL configuration,
I would like to watch and support it.
I am still seeking how to get "class ID" in better way on that
configuration.


On Fri, Mar 25, 2016 at 7:16 AM Alexey Samsonov <vonosmas at gmail.com> wrote:

> Some confusion is going on here. See r264293 which deleted these
> definitions. As a result, I now have "multiple definitions" error while
> trying to link ErrorTest
>
> On Thu, Mar 24, 2016 at 2:17 PM, Lang Hames via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: lhames
>> Date: Thu Mar 24 16:17:50 2016
>> New Revision: 264341
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=264341&view=rev
>> Log:
>> [Support] Add ErrorInfo::ID static member definition.
>>
>> Somehow this got dropped in an earlier patch.
>>
>>
>> Modified:
>>     llvm/trunk/include/llvm/Support/Error.h
>>
>> Modified: llvm/trunk/include/llvm/Support/Error.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Error.h?rev=264341&r1=264340&r2=264341&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/include/llvm/Support/Error.h (original)
>> +++ llvm/trunk/include/llvm/Support/Error.h Thu Mar 24 16:17:50 2016
>> @@ -291,6 +291,9 @@ private:
>>    static char ID;
>>  };
>>
>> +template <typename ThisErrT, typename ParentErrT>
>> +char ErrorInfo<ThisErrT, ParentErrT>::ID = 0;
>> +
>>  /// Special ErrorInfo subclass representing a list of ErrorInfos.
>>  /// Instances of this class are constructed by joinError.
>>  class ErrorList final : public ErrorInfo<ErrorList> {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
>
> --
> Alexey Samsonov
> vonosmas at gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160324/9a2b3b8d/attachment.html>