[PATCH] D15965: Add support for dumping relocations in non-relocatable files

[Shankar Easwaran via llvm-commits]

shankare added a reviewer: shankare.
shankare added a comment.

http://www.sco.com/developers/gabi/latest/ch4.reloc.html

  r_offset
  This member gives the location at which to apply the relocation action. For a relocatable file, the value is the byte offset from the beginning of the section to the storage unit affected by the relocation. For an executable file or a shared object, the value is the virtual address of the storage unit affected by the relocation.

This shows that the assertion is incorrect, as the ELF ABI suggests reading relocation records is valid in Executables as well.

While relocation offset is not looked up for shared libraries from .rela.dyn and .rela.plt sections, there is a usecase where relocation sections are generated with the linker switch **--emit-relocs**

Removing the assertion, LGTM.


Repository:
  rL LLVM

http://reviews.llvm.org/D15965