[PATCH] D18390: Fix logic for which symbols to keep with comdats

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 04:45:19 PDT 2016


On 24 March 2016 at 00:24, Justin Bogner <mail at justinbogner.com> wrote:
> Rafael Ávila de Espíndola via llvm-commits <llvm-commits at lists.llvm.org>
> writes:
>> rafael added a comment.
>>
>> comment for phab to send email to the list.
>
> Note that adding a comment to phab doesn't actually send the patch to
> the list, so it isn't altogether useful. If you want phab to do
> something reasonable you pretty much have to abandon the review and
> create a new one with llvm-commits added in the first place.

Yes, I figured it was a reasonable compromise given that it sends the
subject and a link.

Cheers,
Rafael


More information about the llvm-commits mailing list