[PATCH] D18189: [X86][XOP] Support for VPPERM byte shuffle instruction

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.

================
Comment at: test/CodeGen/X86/vector-shuffle-combining-xop.ll:33-40
@@ +32,9 @@
+
+define <16 x i8> @combine_vpperm_as_unpckhwd(<16 x i8> %a0, <16 x i8> %a1) {
+; CHECK-LABEL: combine_vpperm_as_unpckhwd:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    vpperm {{.*}}(%rip), %xmm1, %xmm0, %xmm0
+; CHECK-NEXT:    retq
+  %res0 = call <16 x i8> @llvm.x86.xop.vpperm(<16 x i8> %a0, <16 x i8> %a1, <16 x i8> <i8 8, i8 24, i8 9, i8 25, i8 10, i8 26, i8 11, i8 27, i8 12, i8 28, i8 13, i8 29, i8 14, i8 30, i8 15, i8 31>)
+  ret <16 x i8> %res0
+}
----------------
spatel wrote:
> Add 2 tests for the load folding variants?
Those are already tested in xop-intrinsics-x86_64.ll


Repository:
  rL LLVM

http://reviews.llvm.org/D18189