[PATCH] D18421: [WIP] MachineFunction Properties

[Derek Schuff via llvm-commits]

dschuff created this revision.
dschuff added reviewers: qcolombet, hfinkel.
dschuff added a subscriber: llvm-commits.
Herald added subscribers: dschuff, jfb, qcolombet, MatzeB, jholewinski.

This is a strawman design for a set of "properties" that a
MachineFunction can have at particular points in time. Currently we have
MachineRegisterInfo::isSSA() and MachineRegisterInfo::tracksLiveness()
and we are also discussing the "post-RA" property (i.e. there are no
virtual register operands). We want an easy way for MachineFunctions to
declare that they require a particular property to hold, and that they
set or clear a particular property. This facility is somewhat similar to
the way passes can declare their required analysis passes, inviting a
comparison of the requirements/use cases:

1) Like analysis passes, passes can require that property hold.
2) Unlike analysis, all possible properties can be listed in one place as
an enum (as opposed to an arbitrary pass ID)
3) Properties can be set by a pass (unlike analysis where the anlysis is
provided by a special kind of pass and managed by a pass manager)
4) Properties may be conditionally cleared (e.g. BranchFolder
conditionally invalidates liveness)

This design just represents the properties as a bit vector stored on the
MachineFunctionObject, and the pass requirements and modifications as
objects on the MachineFunctionPass. Passes can declare that they
require, or unconditionally set or clear properties by setting these
objects in their constructor, (which results in automatic checking) or
they can query or modify the MachineFunction's properties when the pass
is run.

Currently it just implements the "post-RA" property as
AllVRegsAllocated, for X86. It still needs a few fixes and name bikeshedding.

Possible alternative design features/constraints:
- Allow passes to require that a property is clear (instead of just set)
- Make all passes require a particular property unless they clear the
requirement themselves

Possible alternative implementations:
- Return set of set/cleared properties from a query function (similar to
getAnalysisUsage) instead of keeping a static data structure set in the
constructor

http://reviews.llvm.org/D18421

Files:
  include/llvm/CodeGen/MachineFunction.h
  include/llvm/CodeGen/MachineFunctionPass.h
  lib/CodeGen/FuncletLayout.cpp
  lib/CodeGen/ImplicitNullChecks.cpp
  lib/CodeGen/LiveDebugValues.cpp
  lib/CodeGen/MachineCopyPropagation.cpp
  lib/CodeGen/MachineFunctionPass.cpp
  lib/CodeGen/PostRASchedulerList.cpp
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/CodeGen/RegAllocBasic.cpp
  lib/CodeGen/RegAllocFast.cpp
  lib/CodeGen/RegAllocGreedy.cpp
  lib/CodeGen/RegAllocPBQP.cpp
  lib/CodeGen/StackMapLivenessAnalysis.cpp
  lib/Target/NVPTX/NVPTXTargetMachine.cpp
  lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18421.51498.patch
Type: text/x-patch
Size: 15656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160324/b8194030/attachment.bin>