[PATCH] D18415: [LTO] Basic support for internalize.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 16:40:03 PDT 2016


joker.eph added inline comments.

================
Comment at: ELF/LTO.cpp:107
@@ -98,1 +106,3 @@
+            Internalize.insert(GV->getName());
+
           Keep.push_back(GV);
----------------
Can't you change the linkage here immediately instead of using s StringSet.

As a side note, I usually not look at lld but in general this code is lacking documentation, if it was in LLVM it would require a lot more.


http://reviews.llvm.org/D18415





More information about the llvm-commits mailing list