[PATCH] D18411: Codegen: Factor tail duplication into a utility class. NFC

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 14:54:50 PDT 2016


echristo added a comment.

Please clang format :)

One inline comment as well.

Question: Is your next patch going to call this from another pass? If so, I think it makes sense to pull it out from TailDuplication.cpp (yes, leaving that as one of the most boring passes in existence). If not, then I think it's fine as is.

Thanks!

-eric


================
Comment at: include/llvm/CodeGen/TailDuplicator.h:1
@@ +1,2 @@
+//===-- llvm/CodeGen/MachineRegisterInfo.h ----------------------*- C++ -*-===//
+//
----------------
Ahem.


Repository:
  rL LLVM

http://reviews.llvm.org/D18411





More information about the llvm-commits mailing list