[llvm] r264198 - Fix a cut-and-paste error in the changes for r264187 which I think is

Kevin Enderby via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 14:45:21 PDT 2016


Author: enderby
Date: Wed Mar 23 16:45:21 2016
New Revision: 264198

URL: http://llvm.org/viewvc/llvm-project?rev=264198&view=rev
Log:
Fix a cut-and-paste error in the changes for r264187 which I think is
the cause of the tools/llvm-objdump/X86/macho-symbolized-disassembly.test
crashing on linux.  Either way clearly incorrect code.

Modified:
    llvm/trunk/tools/llvm-objdump/MachODump.cpp

Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=264198&r1=264197&r2=264198&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Wed Mar 23 16:45:21 2016
@@ -179,7 +179,7 @@ struct SymbolSorter {
     ErrorOr<SymbolRef::Type> BTypeOrErr = B.getType();
     if (std::error_code EC = BTypeOrErr.getError())
         report_fatal_error(EC.message());
-    SymbolRef::Type BType = *ATypeOrErr;
+    SymbolRef::Type BType = *BTypeOrErr;
     uint64_t AAddr = (AType != SymbolRef::ST_Function) ? 0 : A.getValue();
     uint64_t BAddr = (BType != SymbolRef::ST_Function) ? 0 : B.getValue();
     return AAddr < BAddr;




More information about the llvm-commits mailing list