[PATCH] D18415: [LTO] WIP: Internalize
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 23 14:35:39 PDT 2016
rafael added inline comments.
================
Comment at: ELF/LTO.cpp:82
@@ +81,3 @@
+ M.materializeMetadata();
+ UpgradeDebugInfo(M);
+
----------------
You can leave this for a future patch, no ?
================
Comment at: ELF/Symbols.cpp:19
@@ -18,2 +18,3 @@
#include "llvm/Config/config.h"
+#include "llvm/Support/raw_ostream.h"
----------------
dead include.
================
Comment at: ELF/Symbols.h:185
@@ +184,3 @@
+ void setReferencedFromOutside() { RefFromOutside = true; }
+ bool isReferencedFromOutside() { return RefFromOutside; }
+
----------------
Would it be possible to reuse IsUsedInRegularObj for this?
Repository:
rL LLVM
http://reviews.llvm.org/D18415
More information about the llvm-commits
mailing list