[lld] r264111 - [LTO] Keep linkonce_odr symbols when appropriate.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 13:04:23 PDT 2016


On Wed, Mar 23, 2016 at 12:34 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Wed, Mar 23, 2016 at 11:22 AM, Davide Italiano via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> On Wed, Mar 23, 2016 at 5:15 AM, Rafael EspĂ­ndola
>> <rafael.espindola at gmail.com> wrote:
>> > You only need to change the linkage if you are going to keep it. That
>> > is,
>> > just before the push_back.
>> >
>> > You should also handle linkonce in addition to linkonce_odr.
>> >
>> > On the test, please check the bitcode created by save-temps instead.
>> >
>> > Cheers,
>> > Rafael
>> >
>>
>> Thank you for your review, Rafael. I committed a couple of patches
>> that should address your concerns 1) and 3)
>

r264175, r264176.

Thanks,

--
Davide


More information about the llvm-commits mailing list