[PATCH] D18330: [ELF/AArch64] Implemented set of R_AARCH64_TLSDESC_* relocations.

[Ed Maste via llvm-commits]

emaste added a comment.

minor nits and a question


================
Comment at: ELF/InputSection.cpp:272
@@ -271,1 +271,3 @@
 
+    // TLS descriptor lazy relocations are specific. They
+    // uses two words in the .got.plt. A single relocation is to be used to
----------------
"are specific" seems to be missing information. Maybe "...follow a specific format. They use two..."?

================
Comment at: ELF/InputSection.cpp:275
@@ +274,3 @@
+    // compute the value of the two words of the TLS descriptor.
+    // Overall design can be found in
+    // "Thread-Local Storage Descriptors for IA32 and AMD64/EM64T"
----------------
Maybe mention "is based on" or such to make it clear this wasn't accidentally copied and pasted from X86-specific stuff.

================
Comment at: ELF/OutputSections.cpp:293
@@ +292,3 @@
+  // Tail here is amount of such special relocations.
+  Relocs.insert(Relocs.end() - Tail, Reloc);
+}
----------------
I wonder if there's a nicer way to handle this?

================
Comment at: ELF/OutputSections.h:179
@@ -170,2 +178,3 @@
     Off_GotPlt,    // The got.plt entry of Sym.
+    Off_GotPltRev,
     Off_Bss,       // The bss entry of Sym (copy reloc).
----------------
Comment?


Repository:
  rL LLVM

http://reviews.llvm.org/D18330