[llvm] r264107 - [NVVM] Remove noduplicate attribute from synchronizing intrinsics.

[Justin Lebar via llvm-commits]

Author: jlebar
Date: Tue Mar 22 17:08:01 2016
New Revision: 264107

URL: http://llvm.org/viewvc/llvm-project?rev=264107&view=rev
Log:
[NVVM] Remove noduplicate attribute from synchronizing intrinsics.

Summary:
I've completed my audit of all the code that looks at noduplicate and
added handling of convergent where appropriate, so we no longer need
noduplicate on these intrinsics.

Reviewers: jholewinski

Subscribers: llvm-commits, jholewinski

Differential Revision: http://reviews.llvm.org/D18168

Modified:
    llvm/trunk/include/llvm/IR/IntrinsicsNVVM.td
    llvm/trunk/test/Feature/intrinsic-noduplicate.ll

Modified: llvm/trunk/include/llvm/IR/IntrinsicsNVVM.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/IntrinsicsNVVM.td?rev=264107&r1=264106&r2=264107&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/IntrinsicsNVVM.td (original)
+++ llvm/trunk/include/llvm/IR/IntrinsicsNVVM.td Tue Mar 22 17:08:01 2016
@@ -729,20 +729,16 @@ def llvm_anyi64ptr_ty     : LLVMAnyPoint
                                       [IntrReadWriteArgMem, NoCapture<0>]>;
 
 // Bar.Sync
-//
-// TODO: Remove NoDuplicate here after fixing up LLVM to handle convergent
-// properly.  See discussion in http://reviews.llvm.org/D16941 and
-// http://reviews.llvm.org/D12246.
   def int_cuda_syncthreads : GCCBuiltin<"__syncthreads">,
-      Intrinsic<[], [], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[], [], [IntrConvergent]>;
   def int_nvvm_barrier0 : GCCBuiltin<"__nvvm_bar0">,
-      Intrinsic<[], [], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[], [], [IntrConvergent]>;
   def int_nvvm_barrier0_popc : GCCBuiltin<"__nvvm_bar0_popc">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
   def int_nvvm_barrier0_and : GCCBuiltin<"__nvvm_bar0_and">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
   def int_nvvm_barrier0_or : GCCBuiltin<"__nvvm_bar0_or">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
 
   // Membar
   def int_nvvm_membar_cta : GCCBuiltin<"__nvvm_membar_cta">,

Modified: llvm/trunk/test/Feature/intrinsic-noduplicate.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/intrinsic-noduplicate.ll?rev=264107&r1=264106&r2=264107&view=diff
==============================================================================
--- llvm/trunk/test/Feature/intrinsic-noduplicate.ll (original)
+++ llvm/trunk/test/Feature/intrinsic-noduplicate.ll Tue Mar 22 17:08:01 2016
@@ -1,9 +1,9 @@
 ; RUN: llvm-as < %s | llvm-dis | FileCheck %s
 
-; Make sure LLVM knows about the convergent and noduplicate attributes on the
+; Make sure LLVM knows about the convergent attribute on the
 ; llvm.cuda.syncthreads intrinsic.
 
 declare void @llvm.cuda.syncthreads()
 
 ; CHECK: declare void @llvm.cuda.syncthreads() #[[ATTRNUM:[0-9]+]]
-; CHECK: attributes #[[ATTRNUM]] = { convergent noduplicate nounwind }
+; CHECK: attributes #[[ATTRNUM]] = { convergent nounwind }