[compiler-rt] r264079 - [tsan] Fix check-tsan build by using CHECK_NE.

[Renato Golin via llvm-commits]

Hi Yabin,

The tests are still broken:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/6892

WARNING: Program is run with randomized virtual address space, which
wouldn't work with ThreadSanitizer.

Should we just revert the changes until this is discussed further?

cheers,
--renato

On 22 March 2016 at 18:12, Yabin Cui via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: yabinc
> Date: Tue Mar 22 13:12:18 2016
> New Revision: 264079
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264079&view=rev
> Log:
> [tsan] Fix check-tsan build by using CHECK_NE.
>
> Reviewers: llvm-commits, srhines, dvyukov
>
> Subscribers: srhines
>
> Differential Revision: http://reviews.llvm.org/D18361
>
> Modified:
>     compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc
>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc?rev=264079&r1=264078&r2=264079&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc (original)
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc Tue Mar 22 13:12:18 2016
> @@ -302,7 +302,7 @@ void InitializePlatform() {
>        Report("WARNING: Program is run with randomized virtual address space,"
>               " which wouldn't work with ThreadSanitizer.\n");
>        Report("Re-execing with fixed virtual address space.\n");
> -      CHECK(personality(old_personality | ADDR_NO_RANDOMIZE) != -1);
> +      CHECK_NE(-1, personality(old_personality | ADDR_NO_RANDOMIZE));
>        reexec = true;
>      }
>  #endif
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits