[PATCH] D18305: [InstCombine] Ensure all undef operands are handled before binary instruction constant folding

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: lib/IR/ConstantFold.cpp:1010-1011
@@ -1001,1 +1009,4 @@
+      return nullptr;
+    case Instruction::BinaryOpsEnd:
+      return nullptr;
     }
----------------
I'd make this `llvm_unreachable`.


Repository:
  rL LLVM

http://reviews.llvm.org/D18305