[PATCH] D18305: [InstCombine] Ensure all undef operands are handled before binary instruction constant folding
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 21 12:10:34 PDT 2016
majnemer added inline comments.
================
Comment at: lib/IR/ConstantFold.cpp:923
@@ -920,3 +922,3 @@
if (isa<UndefValue>(C1) || isa<UndefValue>(C2)) {
switch (Opcode) {
case Instruction::Xor:
----------------
Can we make this `switch (static_cast<BinaryOps>(Opcode))`.
This would make the switch fully-covered.
Repository:
rL LLVM
http://reviews.llvm.org/D18305
More information about the llvm-commits
mailing list