[PATCH] D18003: [tsan] Disable randomized address space on linux aarch64.

[Yabin Cui via llvm-commits]

yabinc updated this revision to Diff 51188.
yabinc added a comment.
Herald added a subscriber: rengolin.

Add comment.


http://reviews.llvm.org/D18003

Files:
  lib/tsan/rtl/tsan_platform_linux.cc

Index: lib/tsan/rtl/tsan_platform_linux.cc
===================================================================
--- lib/tsan/rtl/tsan_platform_linux.cc
+++ lib/tsan/rtl/tsan_platform_linux.cc
@@ -36,6 +36,7 @@
 #include <string.h>
 #include <stdarg.h>
 #include <sys/mman.h>
+#include <sys/personality.h>
 #include <sys/syscall.h>
 #include <sys/socket.h>
 #include <sys/time.h>
@@ -291,6 +292,20 @@
       SetAddressSpaceUnlimited();
       reexec = true;
     }
+    // After patch "arm64: mm: support ARCH_MMAP_RND_BITS." is introduced in
+    // linux kernel, the random gap between stack and mapped area is increased
+    // from 128M to 36G on 39-bit aarch64. As it is almost impossible to cover
+    // this big range, we should disable randomized virtual space on aarch64.
+#if defined(__aarch64__)
+    int old_personality = personality(0xffffffff);
+    if (old_personality != -1 && (old_personality & ADDR_NO_RANDOMIZE) == 0) {
+      Report("WARNING: Program is run with randomized virtual address space,"
+             " which wouldn't work with ThreadSanitizer.\n");
+      Report("Re-execing with fixed virtual address space.\n");
+      CHECK(personality(old_personality | ADDR_NO_RANDOMIZE) != -1);
+      reexec = true;
+    }
+#endif
     if (reexec)
       ReExec();
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18003.51188.patch
Type: text/x-patch
Size: 1291 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160321/e63e1000/attachment.bin>