[PATCH] D18305: [InstCombine] Ensure all undef operands are handled before binary instruction constant folding

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/IR/ConstantFold.cpp:1008-1011
@@ -1001,1 +1007,6 @@
+      return nullptr;
+    default:
+      assert(!Instruction::isBinaryOp(Opcode) &&
+             "Unable to handle UNDEFs in this binary instruction");
+      return nullptr;
     }
----------------
ConstantFoldBinaryInstruction should only be called with a binary op, I'd move this assert to the start of the function.


Repository:
  rL LLVM

http://reviews.llvm.org/D18305