[PATCH] D18224: llvm-readobj: GNU style symbols printing

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2549
@@ +2548,3 @@
+        Symbol, FirstSym, this->dumper()->getShndxTable());
+  default:
+    if (SectionIndex >= ELF::SHN_LOPROC && SectionIndex <= ELF::SHN_HIPROC)
----------------
Add a fallthrough comment.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2588
@@ +2587,3 @@
+  }
+  Field fields[8] = {0,         8,         17 + Bias, 23 + Bias,
+                     31 + Bias, 38 + Bias, 47 + Bias, 51 + Bias};
----------------
Start variable name with uppper case.


Repository:
  rL LLVM

http://reviews.llvm.org/D18224