[PATCH] D18308: cmake/lit: Use CMAKE_STRIP variable to provide strip tool name to hash.py
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 21 01:34:34 PDT 2016
jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.
Hi Simon,
LGTM with one change.
Cheers,
James
================
Comment at: CMakeLists.txt:82
@@ +81,3 @@
+# Setup default strip tool used by 'lit'
+if(NOT DEFINED CMAKE_STRIP)
+ set (CMAKE_STRIP "strip")
----------------
CMake discovers "strip" by itself. This variable should never be unset, so you shouldn't need this code here.
(My CMakeCache.txt without this patch applied defines CMAKE_STRIP:FILEPATH=/usr/bin/strip)
Repository:
rL LLVM
http://reviews.llvm.org/D18308
More information about the llvm-commits
mailing list