[PATCH] D18162: AMDGPU: Add SIWholeQuadMode pass
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 18 15:45:00 PDT 2016
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM, just a few things to fix before you commit.
================
Comment at: lib/Target/AMDGPU/AMDGPUInstrInfo.h:65
@@ -64,3 +64,2 @@
-
/// \brief Return a target-specific opcode if Opcode is a pseudo instruction.
----------------
Extra whitespace change.
================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:311
@@ +310,3 @@
+ unsigned SaveWQM, unsigned LiveMaskReg)
+{
+ if (SaveWQM) {
----------------
Coding Style. Brace on new line.
================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:327
@@ +326,3 @@
+ unsigned SavedWQM)
+{
+ if (SavedWQM) {
----------------
Coding Style: Brace on new line.
http://reviews.llvm.org/D18162
More information about the llvm-commits
mailing list