[PATCH] D18224: llvm-readobj: GNU style symbols printing

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 16:43:55 PDT 2016


On 17 March 2016 at 16:26, khemant at codeaurora.org
<khemant at codeaurora.org> wrote:
> khemant added inline comments.
>
> ================
> Comment at: tools/llvm-readobj/ELFDumper.cpp:184
> @@ -184,2 +183,3 @@
>    const Elf_Shdr *DotSymtabSec = nullptr;
> +  const Elf_Shdr *DotDynSymtabSec = nullptr;
>    ArrayRef<Elf_Word> ShndxTable;
> ----------------
> khemant wrote:
>> rafael wrote:
>> > Please avoid adding this.
>> >
>> > You can use dynamic_symbols.
>> >
>> I need a way to get the name of the symbol table (both static and dynamic) when the section is present. Any ideas how do I do it?
>>
>>
> Perhaps storing section name as a StringRef (if found in symbol table) is acceptable?

Yes, that should be fine.

Cheers,
Rafael


More information about the llvm-commits mailing list