[PATCH] D18236: DebugInfo: Add ability to not emit DW_AT_vtable_elem_location for virtual functions.

[David Blaikie via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

looks good - one piece of optional feedback (make the IR writer consistent with the output selection)


================
Comment at: lib/IR/DIBuilder.cpp:698-699
@@ -697,4 +697,4 @@
                     LinkageName, File, LineNo, Ty, isLocalToUnit, isDefinition,
-                    ScopeLine, nullptr, 0, 0, Flags, isOptimized, TParams, Decl,
-                    MDTuple::getTemporary(VMContext, None).release());
+                    ScopeLine, nullptr, 0, -1u, Flags, isOptimized, TParams,
+                    Decl, MDTuple::getTemporary(VMContext, None).release());
 
----------------
Should we just make the IR writer conditional on virtuality, then? seems oddly inconsistent this way?


http://reviews.llvm.org/D18236