[PATCH] D18162: AMDGPU: Add SIWholeQuadMode pass

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUInstrInfo.cpp:67
@@ +66,3 @@
+bool AMDGPUInstrInfo::isSchedulingBoundary(const MachineInstr *MI,
+                                           const MachineBasicBlock *MBB,
+                                           const MachineFunction &MF) const {
----------------
This should go in SIInstrInfo, since it is SI specific.

================
Comment at: lib/Target/AMDGPU/AMDGPUInstrInfo.cpp:70-72
@@ +69,5 @@
+  // Terminators and labels can't be scheduled around.
+  if (MI->isTerminator() || MI->isPosition())
+    return true;
+
+  // Target-independent instructions do not have an implicit-use of EXEC, even
----------------
Can we just call TargetInstrInfo::isSchedulingBoundary() at the end of the function rather than have this check.


http://reviews.llvm.org/D18162