[llvm] r263705 - [llvm-objdump] Add '0x' prefix to a target displacement number to accent its hex format
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 17 03:43:44 PDT 2016
Author: atanasyan
Date: Thu Mar 17 05:43:44 2016
New Revision: 263705
URL: http://llvm.org/viewvc/llvm-project?rev=263705&view=rev
Log:
[llvm-objdump] Add '0x' prefix to a target displacement number to accent its hex format
It might be hard to recognize a hexadecimal number without '0x' prefix.
Besides that '0x' prefix corresponds to GNU objdump behaviour.
Differential Revision: http://reviews.llvm.org/D18207
Added:
llvm/trunk/test/tools/llvm-objdump/hex-displacement.test
Modified:
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
Added: llvm/trunk/test/tools/llvm-objdump/hex-displacement.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/hex-displacement.test?rev=263705&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/hex-displacement.test (added)
+++ llvm/trunk/test/tools/llvm-objdump/hex-displacement.test Thu Mar 17 05:43:44 2016
@@ -0,0 +1,10 @@
+# Check that target displacement has '0x' prefix
+# to accent hex format of the number.
+
+# RUN: llvm-objdump -d %p/Inputs/export.dll.coff-i386 | FileCheck %s
+
+# CHECK: exportfn2:
+# CHECK-NEXT: 10002010: 50 pushl %eax
+# CHECK-NEXT: 10002011: e8 00 00 00 00 calll 0 <exportfn2+0x6>
+# CHECK-NEXT: 10002016: 50 pushl %eax
+# CHECK-NEXT: 10002017: e8 00 00 00 00 calll 0 <exportfn2+0xC>
Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=263705&r1=263704&r2=263705&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu Mar 17 05:43:44 2016
@@ -1142,7 +1142,7 @@ static void DisassembleObject(const Obje
outs() << " <" << TargetName;
uint64_t Disp = Target - TargetAddress;
if (Disp)
- outs() << '+' << utohexstr(Disp);
+ outs() << "+0x" << utohexstr(Disp);
outs() << '>';
}
}
More information about the llvm-commits
mailing list