[PATCH] D18164: [tsan] Do not instrument reads/writes to instruction profile counters.

[Xinliang David Li via llvm-commits]

All right. I am fine with the direction the original patch is going (ignore
counter vars).

thanks,

David

On Wed, Mar 16, 2016 at 5:48 PM, Anna Zaks <zaks.anna at gmail.com> wrote:

> zaks.anna added a comment.
>
> > Fine with that too if that is a must, but what is wrong with test
> configuration  modified to avoid this
>
> >  known limitation?
>
> >  According to Anna, the following configs are tested:
>
>
> I was not talking about any specific test configurations. This is what
> compiler/tools users could choose to use. We (as compiler vendors) have no
> control over this.
>
> > - coverage + tsan
>
> > - coverage + asan .. If the motivation is to save build time (by merging
> intrumentations), How about just
>
> > - coverage + asan
>
> > - tsan -... This is also faster.  There does not seem to be any value to
> repeatedly enable coverage.
>
>
> We do not really control what the users of these tools choose to use in
> their workflow / CI. It is possible they want to use coverage and TSan and
> not care about ASan. Our choice is to either return an error when both
> coverage and tsan are requested or just to support this configuration. I
> think it would be very surprising to users to see that they cannot use
> coverage with TSan. Also, I do not see a reason why it should be disallowed.
>
>
> http://reviews.llvm.org/D18164
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160316/a0118741/attachment.html>