[PATCH] D18213: Add a module Hash in the bitcode and the combined index.

[Rafael Espíndola via llvm-commits]

On 16 March 2016 at 13:51, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> joker.eph added inline comments.
>
> ================
> Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:3200
> @@ +3199,3 @@
> +  auto SHA1 = Stream.getCurrentHash();
> +  unsigned Hash = hash_combine_range(&*SHA1.begin(), &*SHA1.end());
> +
> ----------------
> rafael wrote:
>> This produces different results in 32 and 64 bit machines, no?
> Uh, dunno, is it a property of hash_combine_range?

Correct:

class hash_code {
  size_t value;

Given that you are computing a sha1, you can just get however many
bits from it as you want, no?

Cheers,
Rafael