[PATCH] D18223: Codegen: Decrease minimum jump table density

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 15:29:47 PDT 2016


echristo added a comment.

Some inline comments, I stopped putting ditto down because my hands got tired. :)

-eric


================
Comment at: test/CodeGen/ARM/2011-08-25-ldmia_ret.ll:17
@@ -16,2 +16,3 @@
 
-define i32 @test(i32 %in1, i32 %in2) nounwind {
+; optsize is necessary to reproduce the behavior, because at the time the bug
+; was found, the minimum jump table density was 40 for all functions, but now
----------------
Only one function could probably pass your command line option alternately?

No preference other than it'll isolate the testcase from any other optsize changes that happen.

================
Comment at: test/CodeGen/X86/switch-bt.ll:17
@@ -16,1 +16,3 @@
+; table.
+define void @test(i8* %l) nounwind optsize {
 entry:
----------------
Ditto.

================
Comment at: test/CodeGen/X86/switch-bt.ll:108
@@ -106,1 +107,3 @@
+; optsize necessary to force the backend to not create a jump table.
+define void @test4(i32 %x, i32* %y) optsize {
 ; CHECK-LABEL: test4:
----------------
Ditto.


Repository:
  rL LLVM

http://reviews.llvm.org/D18223





More information about the llvm-commits mailing list