[PATCH] D18106: Extract out a SelectionDAGBuilder::LowerAsStatepoint; NFC

[Philip Reames via llvm-commits]

reames added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:716
@@ -715,9 +715,3 @@
 
-  std::pair<SDValue, SDValue> lowerCallOperands(
-          ImmutableCallSite CS,
-          unsigned ArgIdx,
-          unsigned NumArgs,
-          SDValue Callee,
-          Type *ReturnTy,
-          const BasicBlock *EHPadBB = nullptr,
-          bool IsPatchPoint = false);
+  void populateCallLoweringInfo(TargetLowering::CallLoweringInfo &CLI,
+                                ImmutableCallSite CS, unsigned ArgIdx,
----------------
Comments about what these do would help...

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:721
@@ +720,3 @@
+
+  std::pair<SDValue, SDValue>
+  lowerCallOperands(ImmutableCallSite CS, unsigned ArgIdx, unsigned NumArgs,
----------------
I'm not sure lowerCallOperands is a useful abstraction once you've extracted populateCallLoweringInfo.  Might be worth just inlining it at the two call sites.


http://reviews.llvm.org/D18106