[PATCH] D18218: AMDGPU: use ComplexPattern for offsets in llvm.amdgcn.buffer.load/store.format

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 13:04:05 PDT 2016


nhaehnle created this revision.
nhaehnle added reviewers: arsenm, tstellarAMD, mareko.
nhaehnle added a subscriber: llvm-commits.
Herald added a subscriber: arsenm.

We cannot easily deduce that an offset is in a SGPRs, but the Mesa frontend
cannot easily make use of an explicit soffset parameter. Furthermore, it is
likely that in the future, LLVM will be in a better position that the frontend
to choose an SGPR offset if possible.

Since there aren't any frontend uses of these intrinsics in upstream
repositories yet, I would like to take this opportunity to change the
intrinsic signatures to a single offset parameter, which is then selected
to immediate offsets or voffsets using a ComplexPattern.

http://reviews.llvm.org/D18218

Files:
  include/llvm/IR/IntrinsicsAMDGPU.td
  lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  lib/Target/AMDGPU/SIInstrInfo.td
  lib/Target/AMDGPU/SIInstructions.td
  test/CodeGen/AMDGPU/llvm.amdgcn.buffer.load.format.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.buffer.store.format.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18218.50847.patch
Type: text/x-patch
Size: 20676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160316/fe8bb49c/attachment.bin>


More information about the llvm-commits mailing list