[lld] r263228 - Simplify now that local symbols can use getVA.

[Rafael Espíndola via llvm-commits]

> Probably we are both right but talking about different things. Could
> you remember me the case when MIPS differentiates symbols that are
> born local and those that become local because of hidden visibility? I
> thought you mean the case when public symbol behaves like a local one
> from GOT point of view.

What I mean is that I would expect both

-------------------
  lw      $t0,%got(foo+0x10004)($gp)
  .data
foo:
  .word 0
-------------------

and

------------------------
  lw      $t0,%got(foo+0x10004)($gp)
  .data
.global foo
.hidden foo
foo:
  .word 0
-------------------------

to produce equivalent outputs, but they don't:


Hex dump of section '.got':
  0x00020000 00000000 80000000 00040000          ............

versus

Hex dump of section '.got':
  0x00020000 00000000 80000000 00030000          ............


Cheers,
Rafael