[PATCH] D18212: [sanitizer] On OS X, verify that interceptors work and abort if not, take 2

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 08:57:24 PDT 2016


kubabrecka added a comment.

In http://reviews.llvm.org/D18212#376450, @dvyukov wrote:

> > The issue is that TSan unit tests run with a statically linked runtime, where interceptors don't work, but that's fine, we don't need them.
>
>
> What is the difference between that unit test and normal programs? Normal programs also link tsan runtime statically (or is not the case on Mac?). Can we instead make the test more like a normal program so that it does not need any special handling? Adding runtime flags for the sake of a single weird test does not look good to me.


Normal programs and lit tests always link TSan dynamically on OS X.  Unit tests need a static library because they need to access non-exported symbols.


http://reviews.llvm.org/D18212





More information about the llvm-commits mailing list