[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:148-149
@@ +147,4 @@
+  if (Config->Pie) {
+    if (Config->Shared)
+      error("-shared and -pie may not be used together");
+    if (Config->Static)
----------------
I think this is also something that we are checking for errors too eagerly. -shared implies -pie, so they are not incompatible. It is better to ignore this combination.

================
Comment at: ELF/Driver.cpp:150-151
@@ +149,4 @@
+      error("-shared and -pie may not be used together");
+    if (Config->Static)
+      error("-static and -pie may not be used together");
+  }
----------------
Please remove this code unless you have a valid reason to do so.


http://reviews.llvm.org/D18183