[PATCH] D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 10:22:30 PDT 2016


probinson added a subscriber: probinson.
probinson added a comment.

I'm unqualified to review the Python but one thing in the specification doesn't look right.

> For XFAIL, if each expression is False then the test is expected to fail. As a special case "XFAIL: *" also expects the test to fail.


For XFAIL, if each expression is False then the test is expected to *pass*.  As a special case "XFAIL: *" expects the test to fail.
The xfail-expr-* tests get this right.


http://reviews.llvm.org/D18185





More information about the llvm-commits mailing list