[lld] r263542 - [COFF] Remove an unused function, getFileOff

[David Majnemer via llvm-commits]

Author: majnemer
Date: Tue Mar 15 04:48:18 2016
New Revision: 263542

URL: http://llvm.org/viewvc/llvm-project?rev=263542&view=rev
Log:
[COFF] Remove an unused function, getFileOff

The function was not used and was not functional: all paths would lead
to report_fatal_error or endless stack recursion.

Modified:
    lld/trunk/COFF/Symbols.cpp
    lld/trunk/COFF/Symbols.h

Modified: lld/trunk/COFF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.cpp?rev=263542&r1=263541&r2=263542&view=diff
==============================================================================
--- lld/trunk/COFF/Symbols.cpp (original)
+++ lld/trunk/COFF/Symbols.cpp Tue Mar 15 04:48:18 2016
@@ -162,32 +162,6 @@ std::string SymbolBody::getDebugName() {
   return N;
 }
 
-uint64_t Defined::getFileOff() {
-  switch (kind()) {
-  case DefinedImportDataKind:
-    return cast<DefinedImportData>(this)->getFileOff();
-  case DefinedImportThunkKind:
-    return cast<DefinedImportThunk>(this)->getFileOff();
-  case DefinedLocalImportKind:
-    return cast<DefinedLocalImport>(this)->getFileOff();
-  case DefinedCommonKind:
-    return cast<DefinedCommon>(this)->getFileOff();
-  case DefinedRegularKind:
-    return cast<DefinedRegular>(this)->getFileOff();
-
-  case DefinedBitcodeKind:
-    llvm_unreachable("There is no file offset for a bitcode symbol.");
-  case DefinedAbsoluteKind:
-    llvm_unreachable("Cannot get a file offset for an absolute symbol.");
-  case DefinedRelativeKind:
-    llvm_unreachable("Cannot get a file offset for a relative symbol.");
-  case LazyKind:
-  case UndefinedKind:
-    llvm_unreachable("Cannot get a file offset for an undefined symbol.");
-  }
-  llvm_unreachable("unknown symbol kind");
-}
-
 COFFSymbolRef DefinedCOFF::getCOFFSymbol() {
   size_t SymSize = File->getCOFFObj()->getSymbolTableEntrySize();
   if (SymSize == sizeof(coff_symbol16))

Modified: lld/trunk/COFF/Symbols.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.h?rev=263542&r1=263541&r2=263542&view=diff
==============================================================================
--- lld/trunk/COFF/Symbols.h (original)
+++ lld/trunk/COFF/Symbols.h Tue Mar 15 04:48:18 2016
@@ -125,10 +125,6 @@ public:
   // writer sets and uses RVAs.
   uint64_t getRVA();
 
-  // Returns the file offset of this symbol in the final executable.
-  // The writer uses this information to apply relocations.
-  uint64_t getFileOff();
-
   // Returns the RVA relative to the beginning of the output section.
   // Used to implement SECREL relocation type.
   uint64_t getSecrel();