[lld] r263360 - Split addCopyRelSymbols. NFC.

[Rui Ueyama via llvm-commits]

Addressed in r263502.

On Mon, Mar 14, 2016 at 3:36 PM, Rui Ueyama <ruiu at google.com> wrote:

> Yes, I think it can be. Let me try to do that.
>
> On Mon, Mar 14, 2016 at 3:34 PM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
>
>> > +template <class ELFT>
>> > +uint32_t Writer<ELFT>::getAlignment(SharedSymbol<ELFT> *SS) {
>> > +  const Elf_Sym &Sym = SS->Sym;
>> > +  const Elf_Shdr *Sec = SS->File->getSection(Sym);
>> > +  uintX_t SecAlign = Sec->sh_addralign;
>> > +  int TrailingZeros = std::min(countTrailingZeros(SecAlign),
>> > +
>>  countTrailingZeros((uintX_t)Sym.st_value));
>> > +  return 1 << TrailingZeros;
>> > +}
>>
>> Why is this a member of Writer? It can be a top level static, no?
>>
>> Cheers,
>> Rafael
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160314/e41a3830/attachment.html>