[lld] r263360 - Split addCopyRelSymbols. NFC.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 15:34:48 PDT 2016


> +template <class ELFT>
> +uint32_t Writer<ELFT>::getAlignment(SharedSymbol<ELFT> *SS) {
> +  const Elf_Sym &Sym = SS->Sym;
> +  const Elf_Shdr *Sec = SS->File->getSection(Sym);
> +  uintX_t SecAlign = Sec->sh_addralign;
> +  int TrailingZeros = std::min(countTrailingZeros(SecAlign),
> +                               countTrailingZeros((uintX_t)Sym.st_value));
> +  return 1 << TrailingZeros;
> +}

Why is this a member of Writer? It can be a top level static, no?

Cheers,
Rafael


More information about the llvm-commits mailing list