[PATCH] D18077: Factor out MachineBlockPlacement::fillWorkLists. NFC
David Li via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 14 09:26:20 PDT 2016
davidxl accepted this revision.
davidxl added a reviewer: davidxl.
This revision is now accepted and ready to land.
================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:277
@@ -276,1 +276,3 @@
const BlockFilterSet *BlockFilter);
+ void fillWorkLists(MachineBasicBlock *MBB,
+ SmallPtrSetImpl<BlockChain *> &UpdatedPreds,
----------------
Though not done for existing methods, I think it is better to add a slightly detailed comments for this method. Otherwise the refactoring looks good.
http://reviews.llvm.org/D18077
More information about the llvm-commits
mailing list