[PATCH] D18133: allow branch weight metadata on select instructions (PR26636)

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 09:23:28 PDT 2016


davidxl added inline comments.

================
Comment at: include/llvm/IR/IRBuilder.h:1571
@@ -1570,2 +1570,3 @@
 
   Value *CreateSelect(Value *C, Value *True, Value *False,
+                      const Twine &Name = "", MDNode *ProfWeights = nullptr) {
----------------
Ok.

Is it possible to add a small test case (or update existing test case) to cover this -- i.e., after cloning (i.e via inlining), the meta data is maintained for select?


http://reviews.llvm.org/D18133





More information about the llvm-commits mailing list