[PATCH] D17998: [ELF] implement --warn-common/--no-warn-common

[Rui Ueyama via llvm-commits]

On Sun, Mar 13, 2016 at 12:23 AM, Joerg Sonnenberger via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Sun, Mar 13, 2016 at 12:10:51AM -0800, Rui Ueyama wrote:
> > Is there any case you want to use --warn-common option when linking
> Fortran
> > programs?
>
> I still think it is useful it only warns for different sizes, but if it
> is warnings even when the common definitions are consistent, it is
> useless for that.


By "that", do you mean Fortran?

Anyways, I think this patch is okay. This is consistent -- it warns every
time a common symbol is merged with not exceptions. It is easy to
understand, and in addition to that, it's compatible with GNU linkers.

The other way is to tell the users to use -fno-commons and don't submit
this patch completely, but that's I guess a bit too much.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160313/b1cbdcf0/attachment.html>