[PATCH] D18070: New Kaleidoscope section: Creating object files
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 12 14:31:21 PST 2016
lhames added a comment.
Hi Wilfred,
I haven't had a chance to read the new chapter yet - I hope to do that early next week.
Regarding the chapter ordering - I don't think Chapter 5 is the right place to bring this material in. It should either be introduced before the JIT chapters, or after them. I think after is a better fit: Chapter 8 ("Adding Debug Information") currently has an Ahead-of-time mode section. I'd be inclined to insert your Chapter as a new Chapter 8, making "Adding Debug Information" Chapter 9, and removing the ahead-of-time section.
Cheers,
Lang.
http://reviews.llvm.org/D18070
More information about the llvm-commits
mailing list