[llvm] r263086 - Add a flag to the LLVMContext to disable name for Value other than GlobalValue

[Mehdi Amini via llvm-commits]

Thanks Eric,

I plan to resubmit only after I'll have a cc1 command line flag to enable/disable this instead of a compile-time flag as it is now. 
I'll update the tests to either not rely on the named value or pass the flag to preserve them.

-- 
Mehdi


> On Mar 11, 2016, at 5:52 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
> Hi Mehdi,
> 
> This broke a bunch of clang tests in a release build, a bot that shows the same symptoms is:
> 
> http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1337/consoleFull#15733454949ba4694-19c4-4d7e-bec5-911270d8a58c <http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1337/consoleFull#15733454949ba4694-19c4-4d7e-bec5-911270d8a58c>
> 
> I've gone ahead and reverted this and the associated clang patches as I'm not quite sure what you'd like to do about the tests that are looking for names for parameters etc.
> 
> Thanks!
> 
> -eric
> 
> On Fri, Mar 11, 2016 at 2:39 AM Michel Dänzer <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> On 11.03.2016 02:12, Mehdi Amini via llvm-commits wrote:
> > Should be fixed with r263127.
> 
> It is, thanks!
> 
> 
> --
> Earthling Michel Dänzer               |               http://www.amd.com <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.amd.com&d=BQMFaQ&c=Hw-EJUFt2_D9PK5csBJ29kRV40HqSDXWTLPyZ6W8u84&r=XndYjVJuvcoEtO9BUlAZk8839TPlVRJeJXMNUFEz-qQ&m=X5rL6EBUtrqJECPG3Y_87XZIMxNquhocTP-iTnIY5xk&s=h_YV-TeRjelYwwZxZRP1plpGywojQ9euURI_bkHz9c0&e=>
> Libre software enthusiast             |             Mesa and X developer
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160311/4b32f0d6/attachment.html>